workflows: switch to org-wide golangci-lint job #184
Conversation
roman-khimov
force-pushed
the
new-golangci
branch
from
bee1dbf
to
c5bf03f
Compare
config/main.go:193 gofmt File is not `gofmt`-ed with `-s` `-r 'interface{} -> any'`
internal/client.go:169 gofmt File is not `gofmt`-ed with `-s` `-r 'interface{} -> any'`
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
new-golangci
branch
2 times, most recently
from
1fda964
to
7871491
Compare
| @@ -1,73 +0,0 @@ | |||
| # This file contains all available configuration options | |||
| # with their default values. | |||
There was a problem hiding this comment.
One thing that bugs me is that this can affect local linter runs.
There was a problem hiding this comment.
A make target to download it from .github can be added.
There was a problem hiding this comment.
It should be updated manually if any changes are included into .github's config. Other than that it works OK on my machine.
There was a problem hiding this comment.
Yeah, the only other way to sync is submodules, but it's so inconvenient (especially the need to bump them).
There was a problem hiding this comment.
I think the main thing is that we're still guarded by GH linter job, so if local config is out of sync we'll still see linter job failure and it should be sufficient.
There was a problem hiding this comment.
Let’s keep the current way, it’s good.
Fetch it when needed for local runs. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
new-golangci
branch
from
7871491
to
b483ae7
Compare
roman-khimov
requested review from
carpawell,
AliceInHunterland,
cthulhu-rider and
tatiana-nspcc
No description provided.